Skip to content

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2844 to release-4.0


Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

ref #2843
reduce the updates with a switch.

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

  • add a switch about region flow updates in region heartbeat

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

@nolouch please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/pd/invitations

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 26, 2020
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #2848 into release-4.0 will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2848      +/-   ##
===============================================
+ Coverage        77.31%   77.49%   +0.18%     
===============================================
  Files              208      208              
  Lines            22765    22768       +3     
===============================================
+ Hits             17601    17645      +44     
+ Misses            3829     3804      -25     
+ Partials          1335     1319      -16     
Impacted Files Coverage Δ
server/cluster/cluster.go 80.91% <100.00%> (+0.01%) ⬆️
server/config/config.go 77.65% <100.00%> (+0.08%) ⬆️
pkg/btree/btree.go 86.84% <0.00%> (-0.81%) ⬇️
server/grpc_service.go 59.88% <0.00%> (-0.20%) ⬇️
server/server.go 76.96% <0.00%> (+0.44%) ⬆️
server/schedulers/adjacent_region.go 76.59% <0.00%> (+1.06%) ⬆️
server/cluster/coordinator.go 71.22% <0.00%> (+1.19%) ⬆️
server/member/leader.go 73.54% <0.00%> (+1.55%) ⬆️
server/kv/etcd_kv.go 88.31% <0.00%> (+3.89%) ⬆️
server/tso/tso.go 82.91% <0.00%> (+4.43%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a013a...b314f61. Read the comment docs.

@nolouch nolouch modified the milestones: v4.0.6, v4.0.5 Aug 26, 2020
@jebter
Copy link
Collaborator

jebter commented Aug 27, 2020

/run-all-tests

@jebter
Copy link
Collaborator

jebter commented Aug 27, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 3ebc768 into tikv:release-4.0 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants