-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: add diagnostics service #2024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But there are some error with ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Lonng <heng@lonng.org>
/merge |
/run-all-tests |
@lonng merge failed. |
CI not run. retry... /merge |
/merge |
/run-all-tests |
1 similar comment
/run-all-tests |
@lonng merge failed. |
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
This PR embed
Diagnostics
service to the PD to make it diagnosable. (Part of pingcap/tidb#13567)What is changed and how it works?
Register Diagnostics service to PD at server startup.
Check List
Tests