tests: close gRPC connections after testing #10102
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
| } | ||
|
|
||
| // MustNewGrpcClient must create a new PD grpc client. | ||
| func MustNewGrpcClient(re *require.Assertions, addr string) pdpb.PDClient { |
There was a problem hiding this comment.
How about adding a new function as close for pdClient, it will close this conn?
There was a problem hiding this comment.
Here we just create a gRPC client instead of pd client.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10102 +/- ##
==========================================
+ Coverage 78.38% 78.45% +0.07%
==========================================
Files 518 518
Lines 69476 69475 -1
==========================================
+ Hits 54456 54510 +54
+ Misses 11066 11034 -32
+ Partials 3954 3931 -23
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| _, err = stream.Recv() | ||
| if err != nil { | ||
| isCanceled := strings.Contains(err.Error(), "context canceled") | ||
| isEOF := strings.Contains(err.Error(), "EOF") |
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
3 participants
What problem does this PR solve?
Issue Number: ref #7969
What is changed and how does it work?
Check List
Tests
Release note