Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestScatterRegions is unstable #7109

Closed
HuSharp opened this issue Sep 19, 2023 · 2 comments · Fixed by #7111
Closed

TestScatterRegions is unstable #7109

HuSharp opened this issue Sep 19, 2023 · 2 comments · Fixed by #7111
Assignees
@CabinfeverB
Labels
affects-6.5 severity/minor type/bug The issue is confirmed as a bug. type/ci The issue is related to CI.

Comments

@HuSharp
Copy link
Member

HuSharp commented Sep 19, 2023

Flaky Test

TestScatterRegions

Which jobs are failing

2023-09-19T03:11:12.0251518Z [2023/09/19 03:09:43.999 +00:00] [INFO] [labeler.go:69] ["region labeler GC stopped"]
2023-09-19T03:11:12.0252042Z [2023/09/19 03:09:49.549 +00:00] [INFO] [labeler.go:69] ["region labeler GC stopped"]
2023-09-19T03:11:12.0252689Z --- FAIL: TestScatterRegions (6.88s)
2023-09-19T03:11:12.0253161Z     region_scatterer_test.go:147: 
2023-09-19T03:11:12.0254220Z         	Error Trace:	/home/runner/work/pd/pd/pkg/schedule/scatter/region_scatterer_test.go:147
2023-09-19T03:11:12.0255317Z         	            				/home/runner/work/pd/pd/pkg/schedule/scatter/region_scatterer_test.go:69
2023-09-19T03:11:12.0255858Z         	Error:      	"7" is not greater than or equal to "7.5"
2023-09-19T03:11:12.0256276Z         	Test:       	TestScatterRegions
2023-09-19T03:11:12.0256659Z [2023/09/19 03:09:50.302 +00:00] [INFO] [labeler.go:69] ["region labeler GC stopped"]

CI link

https://github.com/tikv/pd/actions/runs/6230663747/job/16911029516?pr=7092

Reason for failure (if possible)

Anything else
@HuSharp HuSharp added the type/ci The issue is related to CI. label Sep 19, 2023
@CabinfeverB
Copy link
Member

/assign

@CabinfeverB CabinfeverB mentioned this issue Sep 19, 2023
Merged
@CabinfeverB CabinfeverB added the type/bug The issue is confirmed as a bug. label Sep 19, 2023
ti-chi-bot bot added a commit that referenced this issue Sep 20, 2023
@CabinfeverB @ti-chi-bot
scatter: fix incorrect judgment condition (#7111)
24fffdf 
close #7109

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this issue Sep 20, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Sep 20, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7111
a0e9d38 
close tikv#7109

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this issue Sep 20, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Sep 20, 2023
@CabinfeverB @ti-chi-bot
This is an automated cherry-pick of tikv#7111
71060f0 
close tikv#7109

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@CabinfeverB
Copy link
Member

the issue in 7.1 will be fixed by #7028

ti-chi-bot bot added a commit that referenced this issue Oct 7, 2023
@ti-chi-bot @CabinfeverB @ti-chi-bot
scatter: fix incorrect judgment condition (#7111) (#7118)
d499de1 
close #7109

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CabinfeverB CabinfeverB

Labels
affects-6.5 severity/minor type/bug The issue is confirmed as a bug. type/ci The issue is related to CI.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scatter: fix incorrect judgment condition CabinfeverB/pd
2 participants
@CabinfeverB @HuSharp