Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil pointer deference when (*AllocatorManager).GetMember #6381

Closed
JmPotato opened this issue Apr 25, 2023 · 1 comment · Fixed by #6383
Closed

Nil pointer deference when (*AllocatorManager).GetMember #6381

JmPotato opened this issue Apr 25, 2023 · 1 comment · Fixed by #6383
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member 

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x30cd89b]

goroutine 169455 [running]:
github.com/tikv/pd/pkg/tso.(*AllocatorManager).GetMember(...)
	/home/runner/work/pd/pd/pkg/tso/allocator_manager.go:299
github.com/tikv/pd/pkg/tso.(*KeyspaceGroupManager).GetElectionMember(0xc006482000, 0x10089d7?, 0x0?)
	/home/runner/work/pd/pd/pkg/tso/keyspace_group_manager.go:742 +0x15b
github.com/tikv/pd/pkg/mcs/tso/server.(*Server).IsKeyspaceServing(0xc008ae97a0, 0x7a11d70?, 0xc0?)
	/home/runner/work/pd/pd/pkg/mcs/tso/server/server.go:216 +0xf2
github.com/tikv/pd/tests/integrations/mcs.(*TestTSOCluster).WaitForPrimaryServing.func1()
	/home/runner/work/pd/pd/tests/integrations/mcs/cluster.go:114 +0x10f
github.com/stretchr/testify/assert.Eventually.func1()
	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:1737 +0x3a
created by github.com/stretchr/testify/assert.Eventually
	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:1737 +0x3a6
FAIL	github.com/tikv/pd/tests/integrations/tso	56.267s
@JmPotato JmPotato added the type/bug The issue is confirmed as a bug. label Apr 25, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Apr 25, 2023

cc @binshi-bing

@binshi-bing binshi-bing mentioned this issue Apr 25, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Apr 26, 2023
@binshi-bing
mcs, tso: fix Nil pointer deference when (*AllocatorManager).GetMember (
b9513ec 
#6383)

close #6381

If the desired keyspace group fall back to the default keyspace group and the AM isn't initialized, return not served error.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
mcs, tso: fix Nil pointer deference when (*AllocatorManager).GetMember (
9b4b000 
tikv#6383)

close tikv#6381

If the desired keyspace group fall back to the default keyspace group and the AM isn't initialized, return not served error.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mcs, tso: fix Nil pointer deference when (*AllocatorManager).GetMember binshi-bing/pd
2 participants
@JmPotato @lhy1024