-
Notifications
You must be signed in to change notification settings - Fork 24
[to #67] support setting api version in br requests #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
now the help message of |
pingyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM~
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
zeminzhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
pingyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Signed-off-by: Jian Zhang zjsariel@gmail.com
What problem does this PR solve?
Issue Number: [to #67]
Problem Description: Not a problem. In order to backup and restore data between clusters with different API versions, we need to indicate tikv-servers about the target encoding format to either API v1 or v2.
BTW, this PR also solves the following problems:
brwhich is the same as the backup restore tools for TiDB (https://github.com/pingcap/tidb/tree/master/br). It causes misunderstanding aboutbr.--cfflag for thebackup rawcommand which increases the bar to usebrsince users need to understand which column family their data is stored in. This PR removed this flag, makingbreasier to use.What is changed and how does it work?
add a flag for users to indicate the destination API version for backup.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes