Skip to content

Conversation

@zz-jason
Copy link
Member

Signed-off-by: Jian Zhang zjsariel@gmail.com

What problem does this PR solve?

Issue Number: [to #67]

Problem Description: TiKV BR is aimed at backup and restoring data for TiKV-only clusters. Functions related to TiDB cluster are duplicated with existing tools, which leads to misunderstanding of the tool and increases code complexity.

What is changed and how does it work?

remove TiDB related backup and restore commands and some dead codes

Code changes

  • Has interface methods change

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • No side effects

Related changes

  • No related changes

@zz-jason zz-jason requested review from pingyu and zeminzhou March 21, 2022 09:47
…-code

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@zz-jason zz-jason merged commit 9afacac into tikv:main Mar 23, 2022
@zz-jason zz-jason deleted the fix/remove-dead-code branch March 23, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants