Skip to content

pd: handle get members with error #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iosmanthus merged 2 commits into from
Jun 2, 2024
Merged

pd: handle get members with error #452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
556e9fb
handle PD get member error
pingyu Jun 1, 2024
9eb2167
Merge branch 'master' into handle-pd-get-member-with-err
pingyu Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/pd/cluster.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,19 @@ impl Connection {
.get_members(pdpb::GetMembersRequest::default())
.await?
.into_inner();
if let Some(err) = resp
.header
.as_ref()
.and_then(|header| header.error.as_ref())
{
return Err(internal_err!("failed to get PD members, err {:?}", err));
}
if resp.leader.is_none() {
return Err(internal_err!(
"unexpected no PD leader in get member resp: {:?}",
resp
));
}
Ok((client, keyspace_client, resp))
}

Expand Down