Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CI #22

Merged
merged 25 commits into from
Feb 25, 2019
Merged

Refine CI #22

merged 25 commits into from
Feb 25, 2019

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jan 14, 2019

Use cross platform CI. Linux Stable is red ATM due to a clippy problem, don't block merge for that.

@Hoverbear Hoverbear force-pushed the refined-ci branch 12 times, most recently from 4350ff6 to 9c7d176 Compare January 14, 2019 19:33
@Hoverbear Hoverbear self-assigned this Jan 14, 2019
@Hoverbear Hoverbear force-pushed the refined-ci branch 6 times, most recently from 123c815 to c266492 Compare January 15, 2019 00:46
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
Copy link
Contributor

@brson brson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know the answer to my question about 'before_script' but otherwise LGTM!

@brson
Copy link
Contributor

brson commented Jan 30, 2019

It looks like there's a feature that needs to be removed now that clippy is stable:

error[E0554]: #![feature] may not be used on the stable release channel
   --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/raft-0.4.0/src/lib.rs:264:39
    |
264 | #![cfg_attr(feature = "cargo-clippy", feature(tool_lints))]
    |                                       ^^^^^^^^^^^^^^^^^^^

Oh, this is an error in the raft crate! Maybe the stabilization of "cargo-clippy" broke raft on stable?

@brson
Copy link
Contributor

brson commented Jan 30, 2019

It looks like travis itself is timing out on windows while backing up the cargo cache.

It also timed out on linux but in a way that didn't cause an error.

Maybe for now you could remove the cache: cargo line.

@brson
Copy link
Contributor

brson commented Jan 30, 2019

I went ahead and pushed a commit to remove the cargo build cache from travis, see how that affects the windows build.

Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear
Copy link
Contributor Author

Rebased with signoff because somehow I forgot. 🙈

Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Copy link
Contributor

@brson brson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few 'integration' test files that look unrelated to the PR, but I assume you know what you're doing.

@Hoverbear
Copy link
Contributor Author

@brson Let me take a look at them...

@Hoverbear
Copy link
Contributor Author

@brson Yes we moved the tests that require a live TiKV to behind a feature flag. Hence the change.

@Hoverbear Hoverbear merged commit 72f4a17 into master Feb 25, 2019
@sticnarf sticnarf deleted the refined-ci branch April 7, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants