Skip to content

test: stabilize TestClusterIDInReq #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lance6716 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: stabilize TestClusterIDInReq #1894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f87d1
test: stabilize TestClusterIDInReq
lance6716 Feb 11, 2026
b8bcdaf
test: stabilize TestClusterIDInReq
lance6716 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions internal/locate/region_request_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,7 @@ func (s *testRegionRequestToSingleStoreSuite) TestClusterIDInReq() {
s.True(port > 0)
rpcClient := client.NewRPCClient()
s.regionRequestSender.client = &fnClient{fn: func(ctx context.Context, addr string, req *tikvrpc.Request, timeout time.Duration) (response *tikvrpc.Response, err error) {
s.True(req.ClusterId > 0)
s.Greater(req.ClusterId, uint64(0))
return rpcClient.SendRequest(ctx, server.Addr(), req, timeout)
}}
defer func() {
Expand All @@ -1041,9 +1041,12 @@ func (s *testRegionRequestToSingleStoreSuite) TestClusterIDInReq() {
s.Nil(err)
s.NotNil(region)
req := tikvrpc.NewRequest(tikvrpc.CmdGet, &kvrpcpb.GetRequest{Key: []byte("a"), Version: 1})
// send a probe request to make sure the mock server is ready.
s.regionRequestSender.SendReq(retry.NewNoopBackoff(context.Background()), req, region.Region, time.Second)
resp, _, err := s.regionRequestSender.SendReq(bo, req, region.Region, time.Millisecond*10)
// Wait for the gRPC serve loop to start accepting connections before running assertions.
s.Eventually(func() bool {
_, probeErr := rpcClient.SendRequest(context.Background(), server.Addr(), req, time.Second)
return probeErr == nil
}, 3*time.Second, 10*time.Millisecond)
resp, _, err := s.regionRequestSender.SendReq(bo, req, region.Region, time.Second)
s.Nil(err)
s.NotNil(resp)
regionErr, _ := resp.GetRegionError()
Expand Down
Loading