Skip to content

txn: add a keyflag sentinel value defensively to prevent future overflow #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
you06 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

txn: add a keyflag sentinel value defensively to prevent future overflow #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2f1407
add a keyflag sentinel value for defensive
you06 Nov 26, 2025
1bb87ff
Merge branch 'master' into keyflag-sentinel
you06 Dec 8, 2025
9e89611
Merge branch 'master' into keyflag-sentinel
you06 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/unionstore/art/art_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,3 +262,9 @@ func TestDiscardValues(t *testing.T) {
tree.Set([]byte{3}, []byte{4})
})
}

func TestKeyFlagsBoundary(t *testing.T) {
require.LessOrEqual(t, kv.FlagMaxBit, deleteFlag)
validMaxFlag := kv.FlagMaxBit - 1
require.Equal(t, validMaxFlag&kv.KeyFlags(flagMask), validMaxFlag)
}
5 changes: 5 additions & 0 deletions kv/keyflags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ const (
// ends when the lock is acquired.
flagPreviousPresumeKNE

// FlagMaxBit is a sentinel value to indicate the maximum bit of KeyFlags.
// Important: add your flag before it, and the FlagMaxBit should always be the last one.
// It's used to avoid setting flags on the highest bit of KeyFlags.
FlagMaxBit

persistentFlags = flagKeyLocked | flagKeyLockedValExist | flagNeedConstraintCheckInPrewrite
)

Expand Down
Loading