Skip to content

Conversation

@you06
Copy link
Contributor

@you06 you06 commented Dec 4, 2025

  • TiDB Transaction Row
image image
  • trace
image
  • slow log
image

you06 added 3 commits December 3, 2025 16:50
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2025
@you06 you06 changed the title txn: add shared lock metrics txn: add metrics, slowlog and trace span for shared locks Dec 4, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-04 04:49:28.634121853 +0000 UTC m=+498113.447899425: ☑️ agreed by zyguan.
  • 2025-12-04 04:51:46.871695151 +0000 UTC m=+498251.685472723: ☑️ agreed by cfzjywxk.

@cfzjywxk cfzjywxk merged commit 0503a5e into tikv:tidb-8.5-with-shared-lock Dec 4, 2025
2 of 3 checks passed
you06-pingcap pushed a commit to you06/client-go that referenced this pull request Dec 22, 2025
* add metrics for shared lock

Signed-off-by: you06 <you1474600@gmail.com>

* remove SharedLockKeysDuration

Signed-off-by: you06 <you1474600@gmail.com>

* add  span in tracing

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants