Skip to content

Conversation

@zyguan
Copy link
Contributor

@zyguan zyguan commented Nov 6, 2025

Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2025
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2025
@zyguan zyguan marked this pull request as ready for review November 7, 2025 07:24
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
zyguan and others added 3 commits November 17, 2025 07:58
Signed-off-by: zyguan <zhongyangguan@gmail.com>
* implement resolve lock

Signed-off-by: you06 <you1474600@gmail.com>

* remote comment code

Signed-off-by: you06 <you1474600@gmail.com>

* add license

Signed-off-by: you06 <you1474600@gmail.com>

* add test for gc shared lock

Signed-off-by: you06 <you1474600@gmail.com>

* address comment

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 2, 2025
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@you06 you06 requested a review from cfzjywxk December 3, 2025 01:50
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-02 09:36:59.68050165 +0000 UTC m=+342564.494279212: ☑️ agreed by you06.
  • 2025-12-03 02:04:50.727081197 +0000 UTC m=+401835.540858779: ☑️ agreed by cfzjywxk.

@cfzjywxk cfzjywxk merged commit e56bdd7 into tikv:tidb-8.5-with-shared-lock Dec 3, 2025
2 of 3 checks passed
you06-pingcap pushed a commit to you06/client-go that referenced this pull request Dec 22, 2025
* *: add basic support for shared lock

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* update kvproto

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* make some minor updates

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* add basic tests for LockKeys

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* bump kvproto

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* shared lock: support rollback/resolve, add tests (tikv#2)

* implement resolve lock

Signed-off-by: you06 <you1474600@gmail.com>

* remote comment code

Signed-off-by: you06 <you1474600@gmail.com>

* add license

Signed-off-by: you06 <you1474600@gmail.com>

* add test for gc shared lock

Signed-off-by: you06 <you1474600@gmail.com>

* address comment

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>

* fix test (tikv#3)

Signed-off-by: you06 <you1474600@gmail.com>

* txnkv: prevent shared locks from being resolved by accidently

Signed-off-by: zyguan <zhongyangguan@gmail.com>

---------

Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Co-authored-by: you06 <you1474600@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants