Skip to content

Bump gprc version to 1.73.0 - remove deprecated NewSharedBufferPool #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tscolari wants to merge 1 commit into from
Closed

Bump gprc version to 1.73.0 - remove deprecated NewSharedBufferPool #1672

tscolari wants to merge 1 commit into from

Conversation

@tscolari
Copy link

@tscolari tscolari commented Jun 18, 2025

Remove references to grpc.NewSharedBufferPool(), it was removed from the grpc package and causes build to fail - it's always on. (https://pkg.go.dev/google.golang.org/grpc/experimental#WithBufferPool),

This an update on #1526, which seems to be stale for 7 months and with conflicts.
Having the code referencing grpc.NewSharedBufferPool causes it to be impossible to use the client in any system that is up to date on the grpc library.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andylokandy for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 18, 2025

Welcome @tscolari!

It looks like this is your first PR to tikv/client-go 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/client-go. 😃

@ti-chi-bot ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2025
@tscolari
Bump gprc version to 1.73.0
9a1a3c3 
Remove references to `grpc.NewSharedBufferPool()`, it was removed from
the grpc package and causes build to fail - it's always on.
(https://pkg.go.dev/google.golang.org/grpc/experimental#WithBufferPool)

Signed-off-by: Tiago Scolari <git@tscolari.me>
@tscolari tscolari force-pushed the bump-grpc-version-and-fix-deprecated-code branch from e03bdd6 to 9a1a3c3 Compare June 19, 2025 08:50
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Jun 19, 2025
@tscolari
Copy link
Author

tscolari commented Jun 21, 2025

/assign @iosmanthus

@serprex serprex mentioned this pull request Jun 30, 2025
Merged
@tscolari
Copy link
Author

tscolari commented Jul 2, 2025

Thank you 🙇

@tscolari tscolari closed this Jul 2, 2025
@joechenrh joechenrh mentioned this pull request Nov 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@iosmanthus iosmanthus

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tscolari @iosmanthus