Skip to content

Commit

Permalink
Disable flaky TestOpenMetricsNegative
Browse files Browse the repository at this point in the history
  • Loading branch information
tigrannajaryan committed Apr 12, 2022
1 parent f42d3d4 commit cf45f45
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (

const testDir = "./testdata/openmetrics/"

// nolint:unused
var skippedTests = map[string]struct{}{
"bad_clashing_names_0": {}, "bad_clashing_names_1": {}, "bad_clashing_names_2": {},
"bad_counter_values_0": {}, "bad_counter_values_1": {}, "bad_counter_values_2": {},
Expand Down Expand Up @@ -77,6 +78,7 @@ func TestOpenMetricsPositive(t *testing.T) {
testComponent(t, targets, false, "")
}

// nolint:unused
func verifyNegativeTarget(t *testing.T, td *testData, mds []*pdata.ResourceMetrics) {
// failing negative tests are skipped since prometheus scrape package is currently not fully
// compatible with OpenMetrics tests and successfully scrapes some invalid metrics
Expand All @@ -92,6 +94,8 @@ func verifyNegativeTarget(t *testing.T, td *testData, mds []*pdata.ResourceMetri

// Test open metrics negative test cases
func TestOpenMetricsNegative(t *testing.T) {
t.Skip("Flaky test, see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/9119")

targetsMap := getOpenMetricsTestData(true)
targets := make([]*testData, 0)
for k, v := range targetsMap {
Expand Down

0 comments on commit cf45f45

Please sign in to comment.