This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Implement Custom Log File #2 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstauffer
suggested changes
Oct 2, 2017
src/DeleteOldSoftDeletes.php
Outdated
| @@ -9,6 +9,7 @@ | |||
| use Illuminate\Database\Eloquent\SoftDeletes; | |||
| use Illuminate\Support\Collection; | |||
| use Illuminate\Support\Facades\Log; | |||
| use Monolog\Logger; | |||
There was a problem hiding this comment.
Sure, will drop this.
src/DeleteOldSoftDeletes.php
Outdated
| @@ -75,6 +76,10 @@ private function logAffectedRows(Collection $deletedRows) | |||
| if (! $this->config->get('quicksand.log', false) || empty($preparedRows)) { | |||
| return; | |||
| } | |||
|
|
|||
| if (! $this->config->get('quicksand.custom_log_file', false)) { | |||
There was a problem hiding this comment.
I think you mean this to be !! ?
There was a problem hiding this comment.
Oh Damn... yeahr sorry!
| @@ -7,6 +7,10 @@ | |||
| // Whether to log the number of soft deleted records per model | |||
| 'log' => false, | |||
|
|
|||
| // If you log the soft deleted records per model, this is the path where it will be stored | |||
| // false if you want the default laravel log file | |||
There was a problem hiding this comment.
Maybe add a third line of comment showing an example path
|
@LKDevelopment This looks great! One problem: This adds the logs to a custom log file, but it doesn't keep those logs from being written to the default laravel.log file. Is that something you think you could tackle as a part of it? Thanks! |
|
@mattstauffer Should be fixed now. I get all Handlers from the Monolog instance, clear the handlers array, set a new Handler with Log::useFiles and reset all after the log is written :) |
|
@LKDevelopment Great! Nice work! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Happy #Hacktoberfest so let's start with some issues :)
This little PR implements the possibility to use custom log files. You can add a path to a custom file and than it will log to the file there :)