Repository navigation
fix(portability): refuse path traversal in import_into - #15
Merged
faj-design5260 merged 2 commits intoSep 23, 2026
Merged
faj-design5260 merged 2 commits into
faj-design5260 merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import_intobuilds the target path asstore.root / entry["path"]and writes to it without checking that the resolved path stays under
the store root.
../../etc/maliciousor an absolute pathlike
/tmp/escapewould write outside the store directory. Theexport path cannot produce such entries (
relative_toconstrainsthem), but
import_intois a public function that any caller canreach with an arbitrary payload.
Fix: resolve the target path and verify it is relative to the
resolved store root before writing. Refuse with a
ValueErrorif thepath escapes.
Files changed:
packages/core/src/agent_memory/core/portability.py— 2-line guardin
import_intotests/unit/test_portability.py— 5 tests: round-trip, file export,../traversal refusal, absolute path refusal, valid relative path