fix detection if an aesthetic is calculated #935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2014 00:10
- variables can also appear as part of an expression - detection of identifier limits is performed using lookarounds and Perl regular expressions - fix glitch in character range - remove unneeded local variable
|
|
||
| # Determine if aesthetic is calculated | ||
| is_calculated_aes <- function(aesthetics) { | ||
| stats <- rep(FALSE, length(aesthetics)) | ||
| grepl(.calculated_aes_regex, sapply(aesthetics, deparse)) |
There was a problem hiding this comment.
Since aesthetics is a call/name, might be better to do a little computing on the language here, rather than using a complicated regexp.
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regular expressions
Improves #917.