Small (but important) improvement to some themes #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the border thinner, to match the thin border of the panel itself. The border of the panel is thin because it is clipped so it is not possible to match it exactly but this is already an improvement over the previous version.
Facet strips were filled and legend keys were grey while all the rest is black and white and as minimal as possible. Changes are made to match that feel.
|
Cosmetic tweaks to I haven't removed the grid in |
|
No idea why it is closed... Reopening |
|
Would you mind generating a couple of before and after shots for me? |
|
Before Before |
|
Can you mention this PR number in the news? |
|
Done PS: The copy-from-R-graphic-window and paste-inside-github functionality is fantastic! |
hadley
added a commit
that referenced
this pull request
Mar 21, 2014
Small (but important) improvement to some themes
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.