Skip to content

Feature/stat ellipse #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 16, 2014
Merged

Feature/stat ellipse #926

merged 14 commits into from
Mar 16, 2014

Conversation

JoFrhwld
Copy link
Contributor

Basically #878, but merged commits from master.

hadley
hadley reviewed Mar 13, 2014
View reviewed changes
.Rbuildignore
^\.travis\.yml$
^/\.gitattributes$
^.*\.Rproj$
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please back out this change?

@hadley
Copy link
Member

hadley commented Mar 13, 2014

  • Motivate the change in one paragraph, and include it in NEWS.
    In parentheses, reference your github user name and this issue:
    (@hadley, #1234)
  • Check pull request only includes relevant changes.
  • Use the official style.
  • Update documentation and re-run roxygen2
  • Add minimal example, if new graphical feature

@JoFrhwld
Copy link
Contributor Author

I think I've hit the major points.

  • Added a brief paragraph to NEWS
  • Cleaned up the style
  • Rolled back the changes to .Rbuildignore
  • Refactored code so that the ellipse calculation is done by a separate function, calculate_ellipse().
  • Included reference to the car package.

hadley added a commit that referenced this pull request Mar 16, 2014
@hadley
Merge pull request #926 from JoFrhwld/feature/stat-ellipse
276780a 
Feature/stat ellipse
@hadley hadley merged commit 276780a into tidyverse:master Mar 16, 2014
@hadley
Copy link
Member

hadley commented Mar 16, 2014

Looks good - thanks!

@joelgombin joelgombin mentioned this pull request Nov 15, 2014
Open
@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoFrhwld @hadley