Skip to content

New themes that do not overwrite existing ones #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2014
Merged

New themes that do not overwrite existing ones #923

merged 7 commits into from
Mar 17, 2014

Conversation

jiho
Copy link
Contributor

@jiho jiho commented Feb 27, 2014

No description provided.

jiho added 3 commits February 27, 2014 18:12
@jiho
Make theme_bw truly black and white
22b606f 
And improve some alignment and sizes (ticks width matches panel border width etc.)
@jiho
Add theme_white
5ed3c92 
Which is intended to give an aspect similar to theme_grey but with a white background.
@jiho
Do not overwrite theme_bw and change names
7554502
hadley
hadley reviewed Mar 13, 2014
View reviewed changes
R/theme-defaults.r
axis.ticks = element_line(colour = "grey50", size=0.25),
legend.key = element_rect(fill="white", colour = "grey50", size=0.25),
panel.background = element_rect(fill = "white", colour = NA),
panel.border = element_rect(fill = NA, colour = "grey50", size=0.5),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces around = please

@hadley
Copy link
Member

hadley commented Mar 13, 2014

  • Motivate the change in one paragraph, and include it in NEWS.
    In parentheses, reference your github user name and this issue:
    (@hadley, #1234)
  • Check pull request only includes relevant changes.
  • Use the official style.
  • Update documentation and re-run roxygen2
  • Add minimal example, if new graphical feature

@hadley
Copy link
Member

hadley commented Mar 13, 2014

Maybe all themes should be documented in one file? Or at least have @family theme. Would you mind adding that?

@jiho
Copy link
Contributor Author

jiho commented Mar 17, 2014

I also think all themes should be documented in one place. It'll be easier to show the differences. I could do it but I don't want to do it in this PR (I don't think it's the place). Once you've pulled this I'll start a new branch off master and do it there, if that's OK for you.

@hadley
Copy link
Member

hadley commented Mar 17, 2014

Makes sense. I'll merge this after you've made the requested small changes.

@jiho
Copy link
Contributor Author

jiho commented Mar 17, 2014

I thought I pushed before writing my last comment but it wasn't the case. The small fixes are now online.

hadley added a commit that referenced this pull request Mar 17, 2014
@hadley
Merge pull request #923 from jiho/fix/theme_bw
188c8e0 
New themes that do not overwrite existing ones
@hadley hadley merged commit 188c8e0 into tidyverse:master Mar 17, 2014
@hadley
Copy link
Member

hadley commented Mar 17, 2014

Thanks!

@jiho jiho deleted the fix/theme_bw branch March 17, 2014 22:11
@jiho
Copy link
Contributor Author

jiho commented Mar 18, 2014

Here is the new one: #933 ;)

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiho @hadley