fix vertical justification for rotated text

[krlmlr]

Per request, re-issue of #883.

[hadley]

• Motivate the change in one paragraph, and include it in NEWS.
  In parenthesis, reference your github user name and this issue:
  (@hadley, #1234)
• Check pull request only includes relevant changes.
• Use the official style.
• Update documentation and re-run roxygen2
• Add visual test, if bug in graphical function

It would be nice to have a visual test for this. That's currently not well documented but we're working on it this week.

[krlmlr]

Thanks. I'll supply a visual test once it's documented. Are the docs online already?

Re-running roxygen2 is not necessary here. I'll update NEWS.

[hadley]

I've been working on https://github.com/hadley/rifftron - will try to switch over next to that next week.

[hadley]

In the absence of visual tests, would you mind adding a before and after picture to this thread? Will this affect existing code?

[krlmlr]

I have posted "before" and "after" images here. Did you have something else in mind? (I could copy the comment here, if it helps.)

Existing code that tweaked the positioning to work around this behavior might now produce plots that look worse than before, but I haven't checked. Other than that, I think plot quality will improve. Of course, this change doesn't touch rotations that are not multiples of 90° -- these would have to be looked at separately, but I'd expect them to be used much less frequently.

[hadley]

Oh that's perfect. I think it's a minor break to backward compatibility in return for a decent improvement in the defaults.

But can you please expand the note in the news to point out that this will affect existing plots and what you need to do about it (i.e. probably just remove your custom vjust settings).

[krlmlr]

Oh, I think the default looked good before. Things used to look odd only if vjust had a non-standard value (other than 0.5, since then vj == 1 - vj), but vjust is now interpreted correctly in all cases. I have enhanced the note in NEWS, it's perhaps too verbose now.

[hadley]

Thanks!

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/