handles empty args in backwards compatible functions #6711
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
list2(...)withdots_list(..., .ignore_empty = "all")to allow for empty, trailing args to be combined with other argsAdds test with example from #6710
This simple fix would allow for empty args placed in the middle (e.g.,
scale_fill_discrete(breaks = 1:2, , direction = -1L,)works fine). This may not be ideal, but someinject(scale_backward_compatibility(!!!list2(...), *))worked fine in testing (and what I originally did in 6388981 because I forgot howdots_list()worked...)