Skip to content

Fix linetype regression #6097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
don't set na.value = "blank"
  • Loading branch information
teunbrand committed Sep 11, 2024
commit ac3516776f24a41f2a846b30af758749d8b9667c
4 changes: 2 additions & 2 deletions R/scale-linetype.R
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#' scale_linetype_identity() +
#' facet_grid(linetype ~ .) +
#' theme_void(20)
scale_linetype <- function(name = waiver(), ..., na.value = "blank") {
scale_linetype <- function(name = waiver(), ..., na.value = NA) {
discrete_scale(
"linetype", name = name,
palette = pal_linetype(),
Expand All @@ -46,7 +46,7 @@ scale_linetype <- function(name = waiver(), ..., na.value = "blank") {

#' @rdname scale_linetype
#' @export
scale_linetype_binned <- function(name = waiver(), ..., na.value = "blank") {
scale_linetype_binned <- function(name = waiver(), ..., na.value = NA) {
binned_scale(
"linetype", name = name,
palette = pal_binned(pal_linetype()),
Expand Down
2 changes: 1 addition & 1 deletion R/scale-manual.R
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ scale_shape_manual <- function(..., values, breaks = waiver(), na.value = NA) {
#' @seealso
#' Other linetype scales: [scale_linetype()], [scale_linetype_identity()].
#' @export
scale_linetype_manual <- function(..., values, breaks = waiver(), na.value = "blank") {
scale_linetype_manual <- function(..., values, breaks = waiver(), na.value = NA) {
manual_scale("linetype", values, breaks, ..., na.value = na.value)
}

Expand Down
6 changes: 3 additions & 3 deletions man/scale_linetype.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/scale_manual.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.