Skip to content

geom_rect() can derive corners from x/width or y/height #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 10, 2024
Merged

geom_rect() can derive corners from x/width or y/height #5862

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6dc3ba8
required aesthetics to non-missing aes
teunbrand Apr 24, 2024
65030f5
<GeomBar> doesn't inherit `optional_aes`
teunbrand Apr 24, 2024
71923cc
fill missing aes
teunbrand Apr 24, 2024
93b45ad
throw error when unresolveable
teunbrand Apr 24, 2024
99293fd
protect against partial matching
teunbrand Apr 24, 2024
e992f51
add tests
teunbrand Apr 24, 2024
68ce1fc
Merge branch 'main' into flexible_rects
teunbrand Apr 24, 2024
b083634
add news bullet
teunbrand Apr 24, 2024
984749c
adjust docs
teunbrand Apr 24, 2024
41c6090
fallback for corners wired through `params`
teunbrand Apr 26, 2024
83557d7
Merge branch 'main' into flexible_rects
teunbrand May 21, 2024
0581b23
Revert "<GeomBar> doesn't inherit `optional_aes`"
teunbrand May 21, 2024
9395341
adapt `check_required_aesthetics()` to deal with multiple or-logic
teunbrand May 21, 2024
f991ec5
undo aesthetic field voodoo
teunbrand May 21, 2024
b990a2b
fill data from params more reliably
teunbrand May 21, 2024
5d01396
throw error from `resolve_rect()`
teunbrand May 21, 2024
b79e68e
document
teunbrand May 21, 2024
19b36b0
Merge branch 'main' into flexible_rects
teunbrand Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add news bullet
  • Loading branch information
@teunbrand
teunbrand committed Apr 24, 2024
commit b083634f1187133af87b28ba9f58b9e3c20adb0b
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* `geom_rect()` can now derive the required corners positions from `x`/`width`
or `y`/`height` parameterisation (@teunbrand, #5861).

# ggplot2 3.5.1

This is a small release focusing on fixing regressions from 3.5.0 and
Expand Down