Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the RC aims to fix a bug uncovered during reverse dependency checks.
Briefly, in some unnatural circumstances you can create a guide that survives all steps but decides to draw a
zeroGrob()
.Guides$package_box()
cannot estimate the gtable size of these guides.Created on 2024-01-15 with reprex v2.0.2
The solution in this PR is to drop empty guides at the
Guides$draw()
step. The reason we might not want to censor guides as soon as we detect the key is empty, is because some (extension) guides might have genuine reasons for not using a key.