Protection for position scale's call
parameter
#5605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the RC aims to fix a bug uncovered in revdepchecks affecting ~44 packages.
One such example is this:
https://github.com/tidyverse/ggplot2/blob/rc/3.5.0/revdep/problems.md#newly-broken-29
Briefly, if a position scale is invoked in an non-standard way, where the first element of the call is not a name, it provoked an error.
To reproduce this error, the code below causes a function to be the scale's
call[[1]]
:This is now wrapped in a
try_fetch()
block so that this does not cause a failure. Ifcall[[1]]
is not coercible to a character, it is presumed that the scale was not called as part of a scale-wrapper (likescale_y_log10()
) and the call gets replaced withcurrent_call()
.This circumvents the error:
Created on 2023-12-21 with reprex v2.0.2