Ignore empty arguments in theme()
#5604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to the RC aims to fix a bug uncovered in revdepchecks affecting ~32 packages.
One such example is this:
https://github.com/tidyverse/ggplot2/blob/rc/3.5.0/revdep/problems.md#newly-broken-126
Briefly, due to allowing splicing in
theme()
, we're no longer ignoring trailing arguments.The fix is to explicitly ignore empty arguments using
dots_list()
instead oflist2()
.A reprex to reproduce the issue:
Fixed behaviour:
Created on 2023-12-21 with reprex v2.0.2