use approx instead of nearest match when placing secondary ticks #4857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Sorry, somehow I missed I was assigned as a reviewer here. Reading the description of #3581, I think I understand the problem, and this looks good to me.
|
I'm not sure I fully understand everything involved, so I'll abstain from making a comment one way or another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3576
Close #3581
This PR implements a very simple approach to doing proper interpolation to find the placement of the secondary ticks thus removing the small imprecisions that can occur when using secondary axes.