Fix labels/breaks/limits interactions in bin guides #4849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
approved these changes
May 17, 2022
There was a problem hiding this comment.
Does this need any documentation updates anywhere
Is the change to guide-bins-can-show-limits.svg deliberate?
|
I guess it would make sense to add a note in the docs The change in the already present visual test is because this PR fixes a bug that was uncovered as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4831
This PR properly defines how breaks and labels behaves with and without
show.limitsset and in the presence of an overlap between limits and breaks.show.limitslabelsis given as a vector of values thenshow.limitswill be ignored with a warning