Skip to content

Make coord_sf() default use projected coords #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

clauswilke
Copy link
Member

Set default_crs = NULL, as discussed in #4494.

@@ -1,3 +1,3 @@
- vdiffr-svg-engine: 1.0
- vdiffr: 0.3.3
- freetypeharfbuzz: 0.2.6
- freetypeharfbuzz: 0.2.5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasp85 Not entirely sure why this change happened. It doesn't seem to affect any of the reference images. If you think it matters, please let me know what I need to do to change this back. I updated to the latest vdiffr but that didn't seem to make a difference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is because you have an older version of freetypeharfbuzz installed and it records the version last used to validate the tests

@clauswilke
Copy link
Member Author

I think this is done, but I'd like to do a bit more testing and review before committing to these changes.

@MikkoVihtakari
Copy link

MikkoVihtakari commented May 31, 2021

One comment I can see just by skimming the diff: just default_crs = 4326 should be enough (the integer should be passed to st_crs() internally) as with the crs argument in previous versions of ggplot2. Now it says "default_crs = sf::st_crs(4326)" in the documentation.

@clauswilke
Copy link
Member Author

Yes, default_crs = 4326 is sufficient. Just trying to be a bit more explicit and precise in the official documentation. For example, the datum argument has always been datum = sf::st_crs(4326).

@MikkoVihtakari
Copy link

Yep, I saw that now. It's in Usage though. Minor details, but perhaps just write in Details that both sf::st_crs(4326) and 4326 are sufficient and that 4326 will be passed to sf::st_crs?

@thomasp85 thomasp85 merged commit 2902ec0 into tidyverse:v3.3.4-rc Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants