Skip to content

Round down breaks in scale_date to avoid misalignment #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2021
Merged

Round down breaks in scale_date to avoid misalignment #4430

merged 3 commits into from
Apr 21, 2021

Conversation

thomasp85
Copy link
Member

Fix #3965

This PR implements a fix for the misalignment by calling floor() on the breaks returned in get_breaks()

@thomasp85 thomasp85 added this to the ggplot2 3.3.4 milestone Apr 19, 2021
yutannihilation
yutannihilation requested changes Apr 20, 2021
View reviewed changes
yutannihilation
yutannihilation approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The failures on Windows runner seems ignorable.

@thomasp85 thomasp85 merged commit 46cc970 into master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutannihilation yutannihilation yutannihilation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.3.4
Development

Successfully merging this pull request may close these issues.

Misaligned date axis for some custom breaks functions
2 participants
@thomasp85 @yutannihilation