Skip to content

[CI] Switch to pak #4425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Apr 16, 2021

@thomasp85
Copy link
Member

Thanks - there's a new GHA that uses pak and does all of this automatically, so we'll be migrating to that instead

@yutannihilation
Copy link
Member Author

Hmm, yeah, using pak seems better. This pull request still fails to build the pkgdown site...

ERROR: dependencies ‘gtable’, ‘isoband’, ‘scales’ are not available for package ‘ggplot2’

@yutannihilation
Copy link
Member Author

Switched to pak and this seems to work.

https://github.com/yutannihilation/ggplot2/runs/2362084213

@thomasp85
Copy link
Member

Since you are as far as I am and have a better feeling for the CI scripts do you mind updating all the scripts to use pak, i.e. run usethis::use_tidy_github_actions() with the dev version of usethis and make sure to not remove stuff we have added?

@yutannihilation
Copy link
Member Author

Oh, sure. I will.

@yutannihilation yutannihilation changed the title Install pkgdown-only deps [CI] Switch to pak Apr 16, 2021
@yutannihilation
Copy link
Member Author

It seems pak::pkg_deps() doesn't work when there's unavailable packages. We need to fix pak first...

@yutannihilation
Copy link
Member Author

yutannihilation commented Apr 17, 2021

It turned out pak is not quite ready to use in our repo. I'll think if we can add some (probably not very simple) workaround or give up for now.

@thomasp85
Copy link
Member

Ok, let's just fix the pkgdown build for now then... will you roll back the last commits?

@yutannihilation
Copy link
Member Author

Reverted. I'll file a new issue for migrating R-CMD-check.yaml to pak when it's ready.

@thomasp85 thomasp85 merged commit 79be511 into tidyverse:master Apr 20, 2021
swsoyee added a commit to swsoyee/r3dmol that referenced this pull request Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgdown CI error
2 participants