Update vdiffr cases for sf 0.9-7 and fix forbidden "brew cask" #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macOS runner will keep failing until the binary is built on CRAN. We might need to wait for a while. |
|
Hmm, OK, this error on macOS runner is another thing we need to fix. |
yutannihilation
changed the title
|
Thanks! |
|
Ah, "brew cask" issue was already fixed on master yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems sf 0.9-7 (published on CRAN yesterday) introduced a small change on axis labels. This pull request is to update the cases.
Before
After
edit: This pull request also fixes the following error on macOS runner due to the recent change on Homebrew