Don't export LayerSf

[thomasp85]

Fix #3158 This will undo the export of LayerSf

[clauswilke]

I think this is fine, but @yutannihilation should sign off on it too.

[thomasp85]

I'll merge it now as it may otherwise be lost in the process... the layer_type argument is something we can have another time I think...

[clauswilke]

I’m more concerned that we have unexported LayerSf but haven’t added layer_sf() yet. This may have downstream implications for packages under development, e.g. ggrepel. @yutannihilation is the person most likely to have such code floating around somewhere.

[yutannihilation]

Thanks for mentioning me! I think it's fine not to add layer_sf(). We can add it when we get sure it's needed.

One thing, do you think we can remove layer_class argument of layer()? Though this argument is visible to users, this is not usable because no Layer class is exported.

ggplot2/R/layer.r

Line 66 in 033fb52

show.legend = NA, layer_class = Layer) {

It's not necessary but nice if we can remove this to avoid confusion.

[yutannihilation]

Ah, sorry I missed this comment: #3207 (comment)

OK, let's leave layer_class and do this:

We could add "for ggplot2 internal use only" to the documentation to make this clear.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/