Fix coord_map to allow switching axis position #3069
Conversation
| bottom = guide_axis(pos$x, panel_params$x.labels, "bottom", theme), | ||
| top = guide_axis(pos$x, panel_params$x.labels, "top", theme) | ||
| top = guide_axis(pos$x, panel_params$x.labels, "top", theme), | ||
| bottom = guide_axis(pos$x, panel_params$x.labels, "bottom", theme) |
There was a problem hiding this comment.
Just wondering: Is there anything happening here other than changing the order of the two lines? Is there a reason to switch the order?
There was a problem hiding this comment.
Yes, scale_x$axis_order() returns which axis is primary and which is secondary in this order (e.g. "secondary" "primary" meaning the top axis is secondary and the bottom is primary), so for the subsetting in the next line to work, this list needs to follow the same order (which is also why I had to reorder the values in arrange <- panel_params$x.arrange %||% c("secondary", "primary"))
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Fixes #3042 by adding
x.arrangeandy.arrangeas panel params that reflect the primary/secondary axes. The order of theaxeslist elements needed to be swapped becausescale_x$axis_order()gives the top first, then the bottom.