Skip to content

Fix tick misalignment and revert transformation inheritance in sec.axis (#2978) #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 11, 2019
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
2064059
revert 2796 and 2805; adjust sec axis breaks init to respect non-iden…
dpseidel Nov 13, 2018
6fe5cf5
add rescaling to secondary axis
dpseidel Nov 14, 2018
0c258c8
update vdiffr svgs
dpseidel Nov 14, 2018
e211ffe
add positioning and visual tests for sec.axis
dpseidel Nov 15, 2018
b7ac60c
use data_frame() in tests
dpseidel Nov 15, 2018
c036488
Merge remote-tracking branch 'upstream/master' into sec_scale
dpseidel Nov 19, 2018
6f35473
Merge remote-tracking branch 'upstream/master' into revert2796
dpseidel Nov 29, 2018
3c3994f
Add a temporary patch for date time axes
dpseidel Nov 29, 2018
06dae1e
merge tests from sec_scale branch
dpseidel Nov 29, 2018
cfa1086
clean up
dpseidel Nov 30, 2018
b7a85be
Merge remote-tracking branch 'upstream/master' into revert2796
dpseidel Dec 13, 2018
19b13c2
Merge remote-tracking branch 'upstream/master' into revert2796
dpseidel Dec 15, 2018
fded720
update sec.axis test cases
dpseidel Dec 15, 2018
225eb36
apply monotonicity test on unexpanded range
dpseidel Jan 4, 2019
64d6cbc
updated visual tests
dpseidel Jan 4, 2019
3a36f26
update docs for sec axis
dpseidel Jan 19, 2019
6fde6f3
Merge remote-tracking branch 'upstream/master' into revert2796
dpseidel Jan 19, 2019
d89c7e9
add news bullet for bug fix
dpseidel Jan 19, 2019
4625f88
Merge remote-tracking branch 'upstream/master' into revert2796
dpseidel Jan 20, 2019
62d6a46
Merge remote-tracking branch 'upstream/master' into revert2796
dpseidel Jan 21, 2019
6643849
fix data.frame in example
dpseidel Jan 21, 2019
2b29405
test transformation by subtraction
dpseidel Feb 1, 2019
a656a08
Merge branch 'master' into revert2796
dpseidel Feb 1, 2019
2f8b35d
Merge branch 'master' into revert2796
thomasp85 Apr 11, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into revert2796
  • Loading branch information
thomasp85 authored Apr 11, 2019
commit 2f8b35dbb66e35abce1a92a06bf4cf991899d827
58 changes: 55 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
# ggplot2 3.1.1.9000

* `sec_axis()` now places ticks accurately when using nonlinear transformations (@dpseidel, #2978).
This is a minor release with an emphasis on internal changes to make ggplot2
faster and more consistent. The few interface changes will only affect the
aesthetics of the plot in minor ways, and will only potentially break code of
extension developers if they have relied on internals that have been changed.
This release also sees the addition of Hiroaki Yutani (@yutannihilation) to the
core developer team.

## New features

* `geom_hline()`, `geom_vline()`, and `geom_abline()` now throw a warning if the user supplies both an `xintercept`, `yintercept`, or `slope` value and a mapping (@RichardJActon, #2950).
* This release includes a range of internal changes that speeds up plot
generation. None of the changes are user facing and will not break any code,
but in general ggplot2 should feel much faster. The changes includes, but are
not limited to:

- Caching ascent and descent dimensions of text to avoid recalculating it for
every title.
Expand All @@ -13,8 +23,48 @@
- Removing the plyr dependency, replacing plyr functions with faster
equivalents.

* `geom_polygon()` can now draw polygons with holes using the new `subgroup`
aesthetic. This functionality requires R 3.6.0 (@thomasp85, #3128)

* Aesthetic mappings now accept functions that return `NULL` (@yutannihilation,
#2997).

* `stat_function()` now accepts rlang/purrr style anonymous functions for the
`fun` parameter (@dkahle, #3159).

* `geom_rug()` gains an "outside" option to allow for moving the rug tassels to
outside the plot area (@njtierney, #3085) and a `length` option to allow for
changing the length of the rug lines (@daniel-wells, #3109).

## Extensions

* Layers now have a new member function `setup_layer()` which is called at the
very beginning of the plot building process and which has access to the
original input data and the plot object being built. This function allows the
creation of custom layers that autogenerate aesthetic mappings based on the
input data or that filter the input data in some form. This is mainly of
interest to extension developers (@clauswilke, #2872).

* `scale_shape_identity()` now works correctly with `guide = "legend"` (@malcolmbarrett, #3029)
* `x0` and `y0` are now recognized positional aesthetics so they will get scaled
if used in extension geoms and stats (@thomasp85, #3168)

## Minor improvements and bug fixes

* `coord_map()` now can have axes on the top and right (@karawoo, #3042).

* `coord_sf()`, `coord_map()`, and `coord_polar()` now squash `-Inf` and `Inf`
into the min and max of the plot (@yutannihilation, #2972).

* `coord_sf()` graticule lines are now drawn in the same thickness as panel grid
lines in `coord_cartesian()`, and seting panel grid lines to `element_blank()`
now also works in `coord_sf()`
(@clauswilke, #2991, #2525).

* `economics` data has been regenerated. This leads to some changes in the
values of all columns (especially in `psavert`), but more importantly, strips
the grouping attributes from `economics_long`.

* `element_line()` now fills closed arrows (@yutannihilation, #2924).

* Facet strips on the left side of plots now have clipping turned on, preventing
text from running out of the strip and borders from looking thicker than for
Expand Down Expand Up @@ -57,6 +107,8 @@

* `stat_bin()` will now error when the number of bins exceeds 1e6 to avoid
accidentally freezing the user session (@thomasp85).

* `sec_axis()` now places ticks accurately when using nonlinear transformations (@dpseidel, #2978).

* `facet_wrap()` and `facet_grid()` now automatically remove NULL from facet
specs, and accept empty specs (@yutannihilation, #3070, #2986).
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.