Skip to content

Update theme documentation #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Conversation

dpseidel
Copy link
Collaborator

This is a PR to update the theme() documentation with feedback from #2727 and as a part of #2553

includes:

  • linking element_*() throughout doc
  • documenting parameters together according to inheritance to reduce cognitive load
  • updating the intro paragraph
  • linking to aesthetics vignette.

@hadley
Copy link
Member

hadley commented Aug 6, 2018

Can you check out what the tooltip in RStudio looks like for autocomplete on the newly combined arguments? (and put a screenshot here)

@dpseidel
Copy link
Collaborator Author

dpseidel commented Aug 7, 2018

screen shot 2018-08-07 at 9 14 54 am

screen shot 2018-08-07 at 9 16 29 am

screen shot 2018-08-07 at 9 16 43 am

screen shot 2018-08-07 at 9 19 10 am

screen shot 2018-08-07 at 9 20 08 am

screen shot 2018-08-07 at 9 20 28 am

screen shot 2018-08-07 at 9 21 04 am

@dpseidel dpseidel merged commit 442108d into tidyverse:master Aug 7, 2018
@dpseidel dpseidel deleted the theme_docs branch August 8, 2018 17:10
@lock
Copy link

lock bot commented Feb 4, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants