Fix bug: Fill aesthetic does not show in the legend guide for stat_summary #1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please:
I'll do a more detailed code review after that |
Rebase against master so that you get the existing travis fix
|
Excuse me for my delay. Your requirements are ready. |
|
Can you please update the title of this PR (and your others) to be informative. I don't know the indices of the ggplot2 bugs off the top of my head. |
ghost
changed the title
|
Your requirements are ready again. |
|
You don't need to repeat the bug name in the PR title. Just write it as the positive statement, e.g. "Show fill in the legend for stat_summary" |
ghost
changed the title
|
Ready! |
hadley
reviewed
Jul 3, 2017
.travis.yml
Outdated
| @@ -8,6 +8,9 @@ r_github_packages: | |||
| after_success: | |||
| - Rscript -e 'covr::codecov()' | |||
|
|
|||
| before_install: | |||
R/legend-draw.r
Outdated
| @@ -159,7 +159,7 @@ draw_key_smooth <- function(data, params, size) { | |||
| data$alpha <- 1 | |||
|
|
|||
| grobTree( | |||
| if (isTRUE(params$se)) rectGrob(gp = gpar(col = NA, fill = data$fill)), | |||
| if (isTRUE(params$se) | is.null(params$se)) rectGrob(gp = gpar(col = NA, fill = data$fill)), | |||
|
@Emanuelcontreras are you interested in finishing this off? |
This comment has been minimized.
This comment has been minimized.
|
Closing this PR. The issue was resolved via #2567. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I read this bug: #1546
Fill aesthetic does not show in the legend guide for stat_summary
And i want to contribute for its solution.
The results: