Fix annotate without global data #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a unit test for this? I think it can probably just test that the annotation layer has an appropriate dummy table. To make it easier to see this pattern in the future it might be worth defining and using: # Used in annotations to ensure printed even when no
# global data
dummy_data <- function() data.frame(x = NA) |
|
LGTM (please squash the commits when you merge) |
Add to news Fix inherit.aes so dummy data is not called out Define and use dummy_data() to assign data to annotation layers Add tests for dummy data and inherit.aes
thomasp85
force-pushed
the
bug-annotate-without-data
branch
from
b959275 to
2ba4a0d
Compare
|
A feeling of unease as a press merge for the first time :-) |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1655 by adding dummy data to all annotate functions in the way already done for annotate_logticks.