-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Updates to include count & density to fix the use of geom_hexbin #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cf99003
Updates to include count & density to fix the use of geom_hexbin with…
mikebirdgeneau 058389d
Update hexbin.R
mikebirdgeneau 75df121
Update bullet in NEWS
mikebirdgeneau 7265c26
Add simple test for geom_hex to include density and value summaries f…
mikebirdgeneau f97b18b
Update NEWS
mikebirdgeneau 9912f3b
Update hexbin.R
mikebirdgeneau 58cdbb4
Remove accidental commit before renaming file.
mikebirdgeneau 036f649
Merge branch 'master' of github.com:mikebirdgeneau/ggplot2
mikebirdgeneau 5abb77c
Move code from within `hexBinSummarise` to within StatBinhex$compute_…
mikebirdgeneau d086c53
Correct bracket indentation.
mikebirdgeneau 2e59e32
Update News bullet placement.
mikebirdgeneau dfe825f
Update NEWS
mikebirdgeneau 06f4c6a
Update NEWS.md
mikebirdgeneau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
context("geom_hex") | ||
|
||
test_that("density and value summaries available", { | ||
df <- data.frame(x = c(1, 1, 1, 2), y = c(1, 1, 1, 2)) | ||
base <- ggplot(df, aes(x, y)) + | ||
geom_hex() | ||
|
||
out <- layer_data(base) | ||
expect_equal(nrow(out), 2) | ||
expect_equal(out$density, c(0.75, 0.25), tolerance = 1e-7) | ||
expect_equal(out$value, c(3, 1), tolerance = 1e-7) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go at the top of
NEWS.md
(just underneath the version number heading)