Preserve class when adding uneval objects#1624
Merged
hadley merged 3 commits intotidyverse:masterfrom Aug 12, 2016
Merged
Conversation
Current coverage is 65.54%@@ master #1624 diff @@
========================================
Files 158 158
Lines 5546 5548 +2
Methods 0 0
Branches 0 0
========================================
+ Hits 3634 3636 +2
Misses 1912 1912
Partials 0 0
|
Member
|
Could you please add a unit test? |
Member
|
And a bullet to NEWS.md please? |
Member
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug that is the root cause of rstudio/shiny#1178. When adding an
aes()object to aggplot()object, theunevalclass is inadvertently dropped. For example:This PR preserves the class of the object.