Inheritance of elements #1581
Closed
Inheritance of elements #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necessary to solve inheritance problem
changes add_theme, combine_elements adds base_class
# Conflicts: # NEWS.md
Error catching for legend.position and legend.justification
passes all test_that checks except one
added 2 commits
March 14, 2016 14:49
|
If all inherited elements are blank, the final subelement will be reassign element_blank. If any inherited elements are not blank, all subelements will retain original element_text, element_line, or element_rect and thus retain the ability to be set independently. |
|
I'd like to hold off on this until we have the new visual testing setup complete so that we can ensure we don't introduce any regressions. |
|
@Katiedaisey thanks for your work on this! We've decided to go a slightly different route though (as you've seen) |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1567
addresses issues #1555, #1557, #1565, #1567, inheritance in elements
previously subelements such as
panel.grid.major.xwere unable to be changed when inheriting from anelement_blank()element such aspanel.grid.major. Update #1557 addressed this, but left the higher element unable to be changed.p <- ggplot(mtcars) + geom_point(aes(x = wt, y = mpg, colour=factor(gear))) + theme(axis.line = element_line(colour = "pink", size = 3))This update allows access to both subelements and higher elements:
p + theme_classic() + theme(panel.grid.major.x = element_line(colour = "pink", size = rel(4)))p + theme_classic() + theme(panel.grid.major = element_line(colour = "pink", size = rel(4)))and addresses the loss of axes in some themes.
The inheritance scheme necessary for this functionally causes this update to fail one test, however graphical output is as expected.