-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Check for non-zero length before calling list2env() #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For future reference, the issue was fixed in R 3.1.2. |
@@ -1,7 +1,10 @@ | |||
# ggplot2 2.0.0.9000 | |||
# ggplot2 2.0.0.9xxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really matter, but I prefer to just leave it as .9000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll change it back.
LGTM. Want to squash it when you merge? Actually can you also bump the required version to 3.1? |
Check for non-zero length before calling list2env()
OK, I bumped the R version and rebased into one commit. |
Thank you! Any idea when this will be pushed to CRAN for release? |
Is this being made into a release? Would love to be able to bump our version of ggplot2. This package is for example a dependency for the latest release of rstan (the STAN wrapper for R) , which means we can't use some of the latest stuff rolled into that package. |
No. I had to install from HEAD. It broke ggplot on raspberryPI (Debian Jessie) that installs R 3.1.x. This is how I worked around it: Optional step. Only needed If you do not have devtools already installed in R.
Install development version of ggplot2
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This fixes #1444. I'd suggest making a release after merging, since this a blocker for many people.