Skip to content

Check for non-zero length before calling list2env() #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2016
Merged

Conversation

wch
Copy link
Member

@wch wch commented Jan 4, 2016

This fixes #1444. I'd suggest making a release after merging, since this a blocker for many people.

@wch
Copy link
Member Author

wch commented Jan 4, 2016

For future reference, the issue was fixed in R 3.1.2.
wch/r-source@e960933

@@ -1,7 +1,10 @@
# ggplot2 2.0.0.9000
# ggplot2 2.0.0.9xxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really matter, but I prefer to just leave it as .9000

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll change it back.

@hadley
Copy link
Member

hadley commented Jan 4, 2016

LGTM. Want to squash it when you merge?

Actually can you also bump the required version to 3.1?

wch added a commit that referenced this pull request Jan 4, 2016
Check for non-zero length before calling list2env()
@wch wch merged commit c3f38ee into master Jan 4, 2016
@wch
Copy link
Member Author

wch commented Jan 4, 2016

OK, I bumped the R version and rebased into one commit.

@jonrobinson2
Copy link

Thank you! Any idea when this will be pushed to CRAN for release?

@jonrobinson2
Copy link

Is this being made into a release? Would love to be able to bump our version of ggplot2. This package is for example a dependency for the latest release of rstan (the STAN wrapper for R) , which means we can't use some of the latest stuff rolled into that package.

@wch wch deleted the fix-list2env branch January 18, 2016 19:21
@steinmb
Copy link

steinmb commented Feb 10, 2016

Is this being made into a release?

No. I had to install from HEAD. It broke ggplot on raspberryPI (Debian Jessie) that installs R 3.1.x. This is how I worked around it:

Optional step. Only needed If you do not have devtools already installed in R.

install.packages("devtools")

Install development version of ggplot2

devtools::install_github("hadley/ggplot2")

@lock
Copy link

lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peculiar environment Issue in ggplot2_2.0.0: "Error in list2env(members, envir = e) " running R 3.1.1
4 participants