Create correct legend for continuous color even if there is only one color #1077
Conversation
|
It should probably go in the visual tests, but they're not in very good shape right now. Would you mind merging/rebasing (mostly to trigger travis) |
|
Done. What are the main issues, and your further plans concerning visual testing? GitHub shows diffs for images. Travis could push back any changes detected by the visual differ. This doesn't work for pull requests, so contributors will have to sign up for Travis to use this. |
Create correct legend for continuous color even if there is only one color
|
The main issues are I don't remember how they're supposed to work (maybe @wch does), and they probably need to be re-thought now that we can rely on travis to automatically run the tests. It may also be able to outsource some of the diffing given that there are a growing number of "visual diffs as service" companies (although they're mostly aimed at web pages) |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
fixes #943
I have no idea where to plug in a test for this. Perhaps in the examples?