Skip to content

layer.r: added missing error message newline/spacer #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2015
Merged

layer.r: added missing error message newline/spacer #1034

merged 3 commits into from
Jun 11, 2015

Conversation

setempler
Copy link
Contributor

Problem: 'stop' does not separate elements in the dots argument, therefore the error message (R/layer.r line 160f) is clumped:
Reproducible example:

f <- function (a) ggplot(data.frame(x=rnorm(10),y=1:10), aes_q(x=quote(x),y=quote(y),color=a)) + geom_point()
f(1) # runs fine
f(1:3) # returns the error message:
Error: Aesthetics must either be length one, or the same length as the dataProblems:1:3

The fix would result in
...
f(1:3)
Error: Aesthetics must either be length one, or the same length as the data
Problems: 1:3

@hadley
Copy link
Member

hadley commented Dec 9, 2014

Maybe also a full stop after data?

@setempler
Copy link
Contributor Author

in progress

hadley added a commit that referenced this pull request Jun 11, 2015
layer.r: added missing error message newline/spacer
@hadley hadley merged commit 380c3b1 into tidyverse:master Jun 11, 2015
@hadley
Copy link
Member

hadley commented Jun 11, 2015

Thanks!

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants