Error message "Did you use %>% instead of +?" doesn't show if aes is passed to geom_*

[EmilHvitfeldt]

The recent change to ggplot2 that helps people remember to use + instead of %>% is great! however it doesn't show if you passed aes() to geom_*() instead of ggplot().

library(ggplot2)
library(magrittr)

ggplot(mtcars, aes(mpg, cyl)) %>%
  geom_point()
#> Error: `mapping` must be created by `aes()`
#> Did you use %>% instead of +?

ggplot(mtcars) %>%
  geom_point(aes(mpg, cyl))
#> Error: `data` must be a data frame, or other object coercible by `fortify()`, not an S3 object with class uneval
#> Did you accidentally pass `aes()` to the `data` argument?

Created on 2018-08-26 by the reprex
package (v0.2.0).

[clauswilke]

Well, you did accidentally pass aes() to the data argument. :-)

This happens because the data is verified (in fortify(data)) before the mapping (in validate_mapping(mapping):

ggplot2/R/layer.r

Lines 84 to 88 in 6500a30

	data <- fortify(data)
	if (!is.null(mapping)) {
	mapping <- validate_mapping(mapping)
	}

I suspect these two lines of code can simply be switched.

[hadley]

Sounds plausible to me.

[clauswilke]

I have created a PR that switches these two lines. That resolves the issue and doesn't seem to have unexpected side effects.

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/