Fix chat_portkey() error when PORTKEY_VIRTUAL_KEY is not set#1001
Draft
thisisnic wants to merge 1 commit into
Draft
Fix chat_portkey() error when PORTKEY_VIRTUAL_KEY is not set#1001thisisnic wants to merge 1 commit into
thisisnic wants to merge 1 commit into
Conversation
hadley
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
virtual_keydeprecation in #808 madePORTKEY_VIRTUAL_KEYeffectively required for any model not using the@provider/modelformat.Before that change, the virtual key was optional; users with custom Portkey gateways could pass arbitrary model IDs (e.g., AWS Bedrock ARNs) without one. Now
key_get()is only called when the env var actually exists.Marking as draft for now so I can double-check this as it was mostly Claude, but seem reasonable.
Fixes #872