Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate min_rank, dense_rank, percent_rank, & cume_dist #396

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

markfairbanks
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@eutwt eutwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice to have a single-argument assertion for these too, like with desc()

dtplyr/R/tidyeval.R

Lines 154 to 157 in dae58ec

} else if (is_call(x, "desc")) {
if (!has_length(x, 2L)) {
abort("`desc()` expects exactly one argument.")
}

@markfairbanks markfairbanks merged commit 5d71f4c into main Nov 1, 2022
@markfairbanks markfairbanks deleted the rank-funs branch November 1, 2022 20:52
@markfairbanks markfairbanks mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants