Implement expand #225
Merged
Implement expand #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Mar 19, 2021
R/step-subset.R
Outdated
Comment on lines
122
to
126
| if (is.null(x$allow_cartesian)) { | ||
| out$allow.cartesian <- TRUE | ||
| } else { | ||
| out$allow.cartesian <- parent$allow_cartesian | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (is.null(x$allow_cartesian)) { | |
| out$allow.cartesian <- TRUE | |
| } else { | |
| out$allow.cartesian <- parent$allow_cartesian | |
| } | |
| out$allow.cartesian <- parent$allow_cartesian %||% TRUE |
?
There was a problem hiding this comment.
I ended up adding an explicit allow_cartesian = TRUE to step_subset_on() and it made this part much more straightforward
Yep, sounds good to me. I'll leave a comment when it's all ready. |
|
All set for review |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
expand()for usage on lazy data.tables.A couple other small adjustments:
slice_min_max()helper that was causing a note fromdevtools::check().